st7789: improvements #824
Draft
st7789: improvements #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n instead Signed-off-by: deadprogram <ron@hybridgroup.com>
…evice actually comes with one. Signed-off-by: deadprogram <ron@hybridgroup.com>
…ions to display Signed-off-by: deadprogram <ron@hybridgroup.com>
Member
Author
|
Once the Tufty2040 board display is working with these changes, then we can say it is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several improvements to the
st7789driver:It remove the dependency on the
machinepackage by using theinternal/pinpackage. It also defines a newst7789.Businterface type to allow for both SPI and parallel connections to the display. Lastly, it switches the example to use the Adafruit Clue board, since that board actually does come with this display.