🐛(helm) fix OIDC authentication with standard scopes #1740
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview will be available at https://1740-docs.ppr-docs.beta.numerique.gouv.fr/ You can use the existing account with these credentials:
You can also create a new account if you want to. Once this Pull Request is merged, the preview will be destroyed. |
AntoLC
force-pushed
the
fix/conf-oidc-preview
branch
from
841b785 to
a8d251d
Compare
Add OIDC_REDIRECT_ALLOWED_HOSTS setting to dev and feature environments to properly allow Keycloak redirect callbacks after authentication.
AntoLC
force-pushed
the
fix/conf-oidc-preview
branch
from
a8d251d to
94fcec6
Compare
"usual_name" does not seem to be standard, it gives error during login. We replace "usual_name" by "family_name".
AntoLC
force-pushed
the
fix/conf-oidc-preview
branch
from
d60c639 to
a98368a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
"usual_name" in
OIDC_RP_SCOPESdoes not seem to be standard, it gives error during login.We replace "usual_name" by "first_name".
OpenId standard:
https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
Keyclock scopes configured:
https://1740-docs-keycloak.ppr-docs.beta.numerique.gouv.fr/admin/master/console/#/docs/client-scopes
Demo
Gives:
