tests: consolidate editable and isolated fixtures #1194

LecrisUT · 2025-12-14T13:15:43Z

A bit of cleanup in preparation for #1193

LecrisUT · 2025-12-15T04:05:13Z

Ahhh, the tests are failing at too long paths? Well that's really annoying. c094c95 should alleviate this issue for a bit, although it makes the path less navigable.

tests/conftest.py

eirrgang · 2025-12-16T00:41:59Z

tests/conftest.py

 @pytest.fixture
-def package_simple_pyproject_source_dir(
-    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+def package(


I see. So this is now not just a factory for a PackageInfo, but takes care of staging the named package sources into a fresh temporary directory and changing into that directory, which imposes the normalized package layout that motivates all of the file moves. Test functions only need to capture the fixture as an argument if they want to check the hashes. I wish I could think of an alternative name to suggest. This is more readable, overall, I think. The parameterization is not intuitive, but the examples are clear.

I wish I could think of an alternative name to suggest.

Always welcome if you have naming candidates.

Test functions only need to capture the fixture as an argument if they want to check the hashes

Could expose some functionality for it to avoid needing to ignore the fixture in parameters, just haven't found a worthy one to do so with.

Copilot

Pull request overview

This PR consolidates test fixtures for package setup, editable installs, and build isolation into parameterized fixtures, reducing code duplication and improving test maintainability in preparation for #1193.

Introduced centralized package, multiple_packages, isolate, and editable fixtures with parametrization support
Migrated all test files to use the new parametrized fixture approach instead of individual package fixtures
Added comprehensive importlib_editable test package to support more extensive editable installation testing

Reviewed changes

Copilot reviewed 14 out of 43 changed files in this pull request and generated 40 comments.

Show a summary per file

File	Description
tests/conftest.py	Core fixture refactoring: added parametrized `package`, `multiple_packages`, `isolate`, and `editable` fixtures; removed individual package fixtures; introduced `Isolate` and `Editable` dataclasses; updated `process_package` signature
tests/test_setuptools_pep518.py	Migrated to use parametrized `package` fixture instead of `package_simple_setuptools_ext`
tests/test_setuptools_pep517.py	Migrated to use parametrized `package` fixture for simple_setuptools_ext, toml_setuptools_ext, and mixed_setuptools tests
tests/test_pyproject_purelib.py	Migrated to use parametrized `package` fixture instead of `package_simple_purelib_package`
tests/test_pyproject_pep660.py	Removed local `editable_mode` fixture; migrated to use centralized parametrized `editable` fixture and removed `typing` import
tests/test_pyproject_pep518.py	Migrated to use parametrized `package` fixture instead of `package_sdist_config`
tests/test_pyproject_pep517.py	Migrated to use parametrized `package` fixture for multiple test packages (simple_pyproject_script_with_flags, simple_pyproject_source_dir, pep639_pure)
tests/test_pyproject_extra_dirs.py	Migrated to use parametrized `package` fixture instead of `package_filepath_pure`
tests/test_prepare_metadata.py	Migrated to use parametrized `package` fixture instead of `package_simplest_c`
tests/test_hatchling.py	Migrated to use parametrized `package` fixture instead of `package_hatchling`
tests/test_editable.py	Major refactoring: removed helper function `_setup_package_for_editable_layout_tests`; migrated to use centralized `isolate`, `editable`, and `multiple_packages` fixtures; removed now-unused conftest imports
tests/test_dynamic_metadata.py	Migrated all dynamic_metadata tests to use parametrized `package` fixture
tests/test_broken_fallback.py	Migrated to use parametrized `package` fixture instead of `broken_fallback` fixture
tests/packages/importlib_editable/*	Added comprehensive new test package with nested subpackages, extension modules, and pure Python modules to test editable installation import behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-22T16:05:55Z

tests/test_setuptools_pep517.py

 @pytest.mark.compile
 @pytest.mark.configure
-@pytest.mark.usefixtures("package_mixed_setuptools")
+@pytest.mark.parametrize("package", {"mixed_setuptools"}, indirect=True)


The parametrize decorator uses a set {"mixed_setuptools"} instead of the conventional list ["mixed_setuptools"] or tuple ("mixed_setuptools",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:05:55Z

tests/test_pyproject_pep660.py

 )
-@pytest.mark.usefixtures("package_simplest_c")
-def test_pep660_wheel(editable_mode: str, tmp_path: Path):
+@pytest.mark.parametrize("package", {"simplest_c"}, indirect=True)


The parametrize decorator uses a set {"simplest_c"} instead of the conventional list ["simplest_c"] or tuple ("simplest_c",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:05:56Z

tests/test_pyproject_pep517.py



-@pytest.mark.usefixtures("package_pep639_pure")
+@pytest.mark.parametrize("package", {"pep639_pure"}, indirect=True)


The parametrize decorator uses a set {"pep639_pure"} instead of the conventional list ["pep639_pure"] or tuple ("pep639_pure",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:05:56Z

tests/test_editable.py

    ],
 )
-@pytest.mark.usefixtures("navigate_editable")
+@pytest.mark.parametrize("package", {"navigate_editable"}, indirect=True)


The parametrize decorator uses a set {"navigate_editable"} instead of the conventional list ["navigate_editable"] or tuple ("navigate_editable",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:05:57Z

tests/test_dynamic_metadata.py



-@pytest.mark.usefixtures("package_dynamic_metadata")
+@pytest.mark.parametrize("package", {"dynamic_metadata"}, indirect=True)


The parametrize decorator uses a set {"dynamic_metadata"} instead of the conventional list ["dynamic_metadata"] or tuple ("dynamic_metadata",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:06:07Z

tests/test_broken_fallback.py



-@pytest.mark.usefixtures("broken_fallback")
+@pytest.mark.parametrize("package", {"broken_fallback"}, indirect=True)


The parametrize decorator uses a set {"broken_fallback"} instead of the conventional list ["broken_fallback"] or tuple ("broken_fallback",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:06:07Z

tests/test_pyproject_pep517.py



-@pytest.mark.usefixtures("package_pep639_pure")
+@pytest.mark.parametrize("package", {"pep639_pure"}, indirect=True)


The parametrize decorator uses a set {"pep639_pure"} instead of the conventional list ["pep639_pure"] or tuple ("pep639_pure",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:06:07Z

tests/test_prepare_metadata.py



-@pytest.mark.usefixtures("package_simplest_c")
+@pytest.mark.parametrize("package", {"simplest_c"}, indirect=True)


The parametrize decorator uses a set {"simplest_c"} instead of the conventional list ["simplest_c"] or tuple ("simplest_c",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:06:08Z

tests/test_broken_fallback.py



-@pytest.mark.usefixtures("broken_fallback")
+@pytest.mark.parametrize("package", {"broken_fallback"}, indirect=True)


The parametrize decorator uses a set {"broken_fallback"} instead of the conventional list ["broken_fallback"] or tuple ("broken_fallback",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Copilot · 2025-12-22T16:06:08Z

tests/test_setuptools_pep517.py



-@pytest.mark.usefixtures("package_toml_setuptools_ext")
+@pytest.mark.parametrize("package", {"toml_setuptools_ext"}, indirect=True)


The parametrize decorator uses a set {"toml_setuptools_ext"} instead of the conventional list ["toml_setuptools_ext"] or tuple ("toml_setuptools_ext",). While sets are iterable and this technically works, it's non-idiomatic pytest style and can be confusing. Sets are unordered, which could lead to non-deterministic test ordering if multiple values were present. Consider using a list or tuple instead.

Signed-off-by: Cristian Le <git@lecris.dev>

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

Copilot

Pull request overview

Copilot reviewed 14 out of 43 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

LecrisUT force-pushed the chore/fixture branch from bbd1934 to ccde78a Compare December 14, 2025 13:35

LecrisUT mentioned this pull request Dec 14, 2025

Test cases for different use cases of generated files #1193

Open

LecrisUT requested a review from henryiii December 15, 2025 04:00

LecrisUT force-pushed the chore/fixture branch from a12c12e to c094c95 Compare December 15, 2025 05:02

eirrgang reviewed Dec 16, 2025

View reviewed changes

henryiii requested a review from Copilot December 22, 2025 15:57

Copilot started reviewing on behalf of henryiii December 22, 2025 15:59 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

LecrisUT and others added 10 commits December 22, 2025 12:00

Introduce a common package fixture

36ee046

Signed-off-by: Cristian Le <git@lecris.dev>

Consolidate package fixtures

e03720b

Signed-off-by: Cristian Le <git@lecris.dev>

Add a helper for no-build-isolation

017471a

Signed-off-by: Cristian Le <git@lecris.dev>

Introduce editable and insolation fixtures

557d94a

Signed-off-by: Cristian Le <git@lecris.dev>

Consolidate isolate and editable_mode fixture usages

c03eaf1

Signed-off-by: Cristian Le <git@lecris.dev>

Move importlib_edtiable to src-layout

40f43a1

Signed-off-by: Cristian Le <git@lecris.dev>

Add another fixture to consolidate multi-package installs

525d992

Signed-off-by: Cristian Le <git@lecris.dev>

Try to make the test paths more compact

ead14a6

Signed-off-by: Cristian Le <git@lecris.dev>

Use Literal for editable mode

28e4252

Signed-off-by: Cristian Le <git@lecris.dev>

tests: use [] instead of {}

6fac3c8

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

henryiii force-pushed the chore/fixture branch from 92f0fd3 to 6fac3c8 Compare December 22, 2025 17:01

henryiii requested a review from Copilot December 22, 2025 17:08

Copilot started reviewing on behalf of henryiii December 22, 2025 17:13 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

henryiii approved these changes Dec 22, 2025

View reviewed changes

henryiii merged commit 061b687 into scikit-build:main Dec 22, 2025
70 checks passed

henryiii changed the title ~~Consolidate editable and isolated fixtures~~ tests: consolidate editable and isolated fixtures Dec 22, 2025



		@pytest.mark.usefixtures("package_pep639_pure")
		@pytest.mark.parametrize("package", {"pep639_pure"}, indirect=True)



		@pytest.mark.usefixtures("package_dynamic_metadata")
		@pytest.mark.parametrize("package", {"dynamic_metadata"}, indirect=True)



		@pytest.mark.usefixtures("broken_fallback")
		@pytest.mark.parametrize("package", {"broken_fallback"}, indirect=True)



		@pytest.mark.usefixtures("package_simplest_c")
		@pytest.mark.parametrize("package", {"simplest_c"}, indirect=True)



		@pytest.mark.usefixtures("package_toml_setuptools_ext")
		@pytest.mark.parametrize("package", {"toml_setuptools_ext"}, indirect=True)

tests: consolidate editable and isolated fixtures #1194

tests: consolidate editable and isolated fixtures #1194

Uh oh!

Conversation

LecrisUT commented Dec 14, 2025

Uh oh!

LecrisUT commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

eirrgang Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

LecrisUT Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LecrisUT commented Dec 15, 2025 •

edited

Loading