docs(rtk-query): Clarify standard slice exports #4833
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing documentation implies that standard slices *only* export action creators and reducers. This can create confusion when users compare this with fuller implementations within the codebase, such as the `postsSlice.ts` example shown earlier in Part 6. That file demonstrates that robust slices require exporting additional items like async thunks, types, selectors, and listener middleware. This change updates the wording to clarify that the original statement refers to the *minimal* exports needed from `createSlice`, providing better and unambiguous context before contrasting with `createApi` exports.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing documentation implies that standard slices only export action creators and reducers. This can create confusion when users compare this with fuller implementations within the codebase, such as the
postsSlice.tsexample shown earlier in Part 6.That file demonstrates that robust slices require exporting additional items like async thunks, types, selectors, and listener middleware.
This change updates the wording to clarify that the original statement refers to the minimal exports needed from
createSlice, providing better and unambiguous context before contrasting withcreateApiexports.Thanks for the PR!
To better assist you, please select the type of PR you want to create.
Click the "Preview" tab above, and click on the link for the PR type: