Skip to content

Conversation

@kash2104
Copy link
Contributor

@kash2104 kash2104 commented Dec 15, 2025

What kind of change does this PR introduce?

This PR updates DefaultCIIBestPracticesClient to support configuring the CII Best Practices base URL via an environment variable.

(Is it a bug fix, feature, docs update, something else?)
feature

What is the current behavior?

DefaultCIIBestPracticesClient always uses the hard-coded URL https://www.bestpractices.dev when querying CII Best Practices badge data.

What is the new behavior (if this is a feature change)?**

If the CII_BEST_PRACTICES_URL environment variable is set, DefaultCIIBestPracticesClient will use it as the base URL.
If not set, the client falls back to the existing default URL.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4315

Special notes for your reviewer

Does this PR introduce a user-facing change?

No

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

@kash2104 kash2104 requested a review from a team as a code owner December 15, 2025 16:23
@kash2104 kash2104 requested review from AdamKorcz and jeffmendoza and removed request for a team December 15, 2025 16:23
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 15, 2025
@kash2104 kash2104 force-pushed the issue-4315 branch 3 times, most recently from 4c0f768 to 50c1e48 Compare December 15, 2025 18:03
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.70%. Comparing base (353ed60) to head (50309bd).
⚠️ Report is 297 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4882      +/-   ##
==========================================
+ Coverage   66.80%   69.70%   +2.89%     
==========================================
  Files         230      251      +21     
  Lines       16602    15649     -953     
==========================================
- Hits        11091    10908     -183     
+ Misses       4808     3867     -941     
- Partials      703      874     +171     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one minor change

@spencerschrock
Copy link
Member

/scdiff generate CII-Best-Practices

@github-actions
Copy link

Signed-off-by: kash2104 <kparikh1104@gmail.com>
Signed-off-by: kash2104 <kparikh1104@gmail.com>
@spencerschrock
Copy link
Member

Thanks!

@spencerschrock spencerschrock merged commit 66c42b6 into ossf:main Dec 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature: Check custom CII Best Practices URL

2 participants