Fix bug in collecting metrics of long running queries #44942
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
approved these changes
Dec 16, 2025
github-actions
bot
added
receiver/sqlserver
Run Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query metrics collection window currently misses the collection of long running queries (those ran for > 2 minutes).
In the collector query we check if the
last_execution_timeof query is within the collection window. But technically thelast_execution_timeof a query is the execution start time and this is only recorded once the execution is finished.Because of this behaviour, long ran queries will never be collected with the existing method.
Instead of looking at just the
last_execution_time, we should considerlast_execution_time + last_elapsed_timeof the query to be in the required collection window.Link to tracking issue
Fixes #44984
Testing
Test files updated