Improve log messages when a partial success happens for traces #44927
+1,030
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
ChrsMark
reviewed
Dec 15, 2025
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
Should those failing checks be taken into account?
2025/12/13 09:29:15 [exporter/coralogixexporter] these functions should not be exported: "BuildPartialSuccessLogFieldsForTraces"
[exporter/coralogixexporter] these structs are not part of config and cannot be exported: validation.TooBigSpanDetail,validation.InvalidTraceIDDetail,validation.InvalidSpanIDDetail,validation.BaseSpanDetail,validation.InvalidStartTimeDetail,validation.InvalidSpanDetail,validation.MissingAttributeDetail
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…contrib into 44926
…tor-contrib into 44926
douglascamata
suggested changes
Dec 16, 2025
povilasv
approved these changes
Dec 17, 2025
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
douglascamata
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking issue
Fixes #44926
Testing