Skip to content

Conversation

@richardlau
Copy link
Member

Add git node v8 deps to (re)sync V8 dependencies from V8's DEPS file.


I started on this while exploring potentially adding Chromium's Rust crates (third_party/rust) to the Node.js source tree (although it looks like we might do our own vendoring to potentially allow other uses of Rust). It will also be useful for exploring adding third_party/libc++/src for V8's custom_libcxx to avoid requiring libatomic.

On its own it shouldn't do anything (other than revert any patches we have floated on top of the third_party deps). Its main use would be to test updates to lib/update-v8/constants.js or even V8's DEPS (if we ever want to roll forward a dependency (I expect that to be rare/unlikely)).

Add `git node v8 deps` to (re)sync V8 dependencies from V8's `DEPS`
file.
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.58%. Comparing base (d05ef11) to head (6f241c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1016   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          39       39           
  Lines        4754     4754           
=======================================
  Hits         3831     3831           
  Misses        923      923           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung merged commit aadc4fc into nodejs:main Dec 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants