refactor: Migrate away from \OCP\IDBConnection::insertIfNotExist #57124
+127
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
leftybournes
and removed request for
a team
tcitworld
reviewed
Dec 17, 2025
| if ($e->getReason() === Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) { | ||
| $mountPoint = $tmpMountPointName . '-' . $i; | ||
| $i++; | ||
| continue; |
Member
Author
There was a problem hiding this comment.
Yes, but this was already the case before. The sharding tests are running into a timeout on some tests, so that could be related (but I don't see why yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unique index must be used to actually guarantee no duplicates, as this method is not even transaction safe (with READ_COMMITTED)