Security: Pin action SHAs and add explicit permissions #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add explicit permissions blocks to all jobs (contents: read minimum) - Pin all GitHub Actions to full commit SHAs instead of tags - Actions pinned: - actions/checkout@11bd719 (v4.2.2) - docker/setup-buildx-action@b5ca514 (v3.10.0) - docker/login-action@74a5d14 (v3.4.0) - docker/metadata-action@902fa8c (v5.7.0) - docker/build-push-action@4f58ea7 (v6.9.0) - aquasecurity/trivy-action@6e7b7d1 (master) - DavidAnson/markdownlint-cli2-action@82b32f7 (v14.0.0) This resolves GitHub Security alerts for: - Unpinned actions (prevents supply chain attacks) - Missing explicit permissions (follows principle of least privilege)
- markdownlint-cli2-action: v22.0.0 @ 07035fd053f7be764496c0f8d8f9f41f98305101 - setup-buildx-action: v3.12.0 @ 8d2750c68a42422c14e847fe6c8ac0403b4cbd6f - login-action: v3.6.0 @ 5e57cd118135c172c3672efd75eb46360885c0ef - metadata-action: v5.10.0 @ c299e40c65443455700f0fdfc63efafe5b349051 - build-push-action: v6.18.0 @ 263435318d21b8e681c14492fe198d362a7d2c83 Fixes invalid markdownlint-cli2-action SHA that was causing workflow failures.
- Exclude Makefile from secret detection check (contains template placeholders) - Fix table formatting in QUICKSTART.md (MD060) - add spaces around pipes - Fix duplicate heading in README.md (MD024) - rename second "Traefik Integration" to "Manual Traefik Configuration"
The docker/metadata-action configuration had `type=sha,prefix={{branch}}-`
which generated invalid Docker tags with leading hyphens (e.g.,
`ghcr.io/netresearch/moodle-docker/moodle:-36c8772`) when the branch
placeholder was empty or not properly resolved in PR contexts.
Changed to `type=sha` to generate valid tags like `sha-36c8772` instead.
Fixes #12 build failure: "invalid reference format"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves GitHub Security alerts by implementing workflow security best practices:
contents: read)Security Improvements
Explicit Permissions
All jobs now have explicit permission declarations following the principle of least privilege:
validate-compose:contents: readbuild-moodle-image:contents: read,packages: writetest-stack-startup:contents: readsecurity-scan:contents: readmarkdown-lint:contents: readAction SHA Pinning
All actions are now pinned to full commit SHAs to prevent supply chain attacks:
11bd71901bbe5b1630ceea73d27597364c9af683b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a274a5d142397b4f367a81961eba4e8cd7edddf772902fa8c0b3dc0d3bba63c0d8ea8a87b5be5c08e94f58ea79222b3b9dc2c8bbdd6debcef730109a756e7b7d1fd3e4fef0c5fa8cce1229c54b2c9bd0d882b32f7aaebcf01d06b69f1ec84a31fc90eb416aTesting
References
Resolves GitHub Security alerts for workflow configuration.