Add editorBracketMatch-foreground color setting #284031
Open
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new editorBracketMatch.foreground color setting that allows users to customize the text color of matching brackets. The implementation involves registering a new theme color, updating CSS styling, and ensuring the color properly overrides bracket pair colorization when both features are enabled.
Key Changes
- Added
editorBracketMatch.foregroundcolor registration (defaults to null for backward compatibility) - Changed bracket match decorations from
classNametoinlineClassNameto properly apply text color styling - Added theming participant with
!importantto ensure bracket match foreground overrides bracket pair colorization colors
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/editor/common/core/editorColorRegistry.ts |
Registers new editorBracketMatch.foreground color with null default value and localized description |
src/vs/editor/contrib/bracketMatching/browser/bracketMatching.ts |
Changes decoration options from className to inlineClassName and adds theming participant to apply foreground color with !important override |
src/vs/editor/contrib/bracketMatching/browser/bracketMatching.css |
Adds CSS variable for foreground color to bracket-match class |
build/lib/stylelint/vscode-known-variables.json |
Adds new CSS variable to known variables list for stylelint validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85775
Added new color
editorBracketMatch-foreground(defaults tonull) and use it for matching brackets foreground color.It would be possible to avoid themeing participant when bracket pair colorization is off, but I think the scenario with that setting enabled and foreground color being set is a valid one, hence this approach.