Add conditional for Python agent tools #25677
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorjboyd
added
bug
eleanorjboyd
added
the
skip package*.json
DonJayamanne
requested changes
Dec 17, 2025
DonJayamanne
left a comment
DonJayamanne
left a comment
There was a problem hiding this comment.
This solution will break simple prompts such as create a python file to do xyz and verify it works correctly
The problem here is that the model uses this tool to install npm packages.
Thats wrong.
I would try updating the prompts to include text such as Do NOT use this tool to install npm or other non-python packages
package.json
Outdated
| "required": [] | ||
| } | ||
| }, | ||
| "when": "editorLangId == python || resourceLangId == python || notebookType == jupyter-notebook" |
There was a problem hiding this comment.
This would break simple cases like a pomrpt such as create a python/notebook file that does ....
Member
Author
There was a problem hiding this comment.
gotcha- I was going off of Connor's comment about using a "when" statement but this makes sense
scutuatua-crypto
approved these changes
Dec 21, 2025
scutuatua-crypto
approved these changes
Dec 21, 2025
scutuatua-crypto
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25644