Fix tsp-openapi3 to emit valid @tagMetadata for tags without descriptions #9160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI-to-TypeSpec converter generated invalid
@tagMetadata("tag")decorators for tags lacking descriptions, causing compilation errors since the decorator requires exactly 2 arguments.Changes
generate-tags.ts: Emit@tagMetadata("tag", #{})with empty metadata object instead of single-argument form when tag has no description or externalDocstag-without-descriptionspec validates conversion of tags without metadataplayground-http-servicenow correctly generates two-argument formExample
OpenAPI input:
Generated TypeSpec (before):
Generated TypeSpec (after):
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/usr/local/bin/node node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/astro.js build sh -c ebsite/src/content/docs/docs/emitters/openapi3/reference node pec/node_modules/.bin/sh warn-as-error --sh . .0/bin/sh node /hom�� astro check --minimumFailingSeverity hint && astro build node .0_tmp_3586/node_modules/pnpm/dist/node-gyp-bin/node --no-emit sh _modules/pnpm/ditsx ./.scripts/regen-compiler-docs.ts sh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.