Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 17, 2025

Add regression test to verify the banner is not displayed when running in server mode, per issue #6888 comment.

Changes

  • Added RunningInServerMode_BannerIsSkipped() test in ServerLoggingTests.cs
  • Test validates that logs collected during server mode execution do not contain the banner pattern Microsoft\.Testing\.Platform v.+ \[.+\]
  • Leverages existing ServerModeTestsBase infrastructure and test assets

The test ensures the behavior in TerminalOutputDevice.cs:209 (if (!_bannerDisplayed && !_isServerMode)) is preserved.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • l49vsblobprodcus358.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.25615.1.txt (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Add test for banner being skipped in server mode</issue_title>
<issue_description>> @nohwnd @Youssef1313 let's try to consider adding a test that would prevent regression (doesn't have to be done right away if you are in rush with some release).

Originally posted by @Evangelink in #6888 (comment)
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI changed the title [WIP] Add test for banner being skipped in server mode Add test for banner skip in server mode Dec 17, 2025
Copilot AI requested a review from Evangelink December 17, 2025 11:20
@Evangelink Evangelink marked this pull request as ready for review December 17, 2025 12:44
@Evangelink Evangelink enabled auto-merge (squash) December 17, 2025 12:44
@Evangelink Evangelink merged commit a4cdeb6 into main Dec 17, 2025
11 checks passed
@Evangelink Evangelink deleted the copilot/add-test-banner-skipped branch December 17, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for banner being skipped in server mode

3 participants