wip: use ed25519 instead of rsa for generating ssh

[medyagh]

No description provided.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/ok-to-test

[k8s-ci-robot]

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-vfkit-docker-macos-arm64	d8910ae	link	false	/test integration-vfkit-docker-macos-arm64
integration-docker-crio-linux-x86-64	d8910ae	link	true	/test integration-docker-crio-linux-x86-64
integration-kvm-crio-linux-x86-64	d8910ae	link	true	/test integration-kvm-crio-linux-x86-64
integration-kvm-docker-linux-x86-64	d8910ae	link	true	/test integration-kvm-docker-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22182 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 39.3s    │ 40.1s                  │
│ enable ingress │ 15.8s    │ 15.4s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube ingress: 15.7s 15.7s 15.8s 15.8s 16.2s
Times for minikube (PR 22182) ingress: 15.7s 15.7s 15.3s 14.7s 15.7s

Times for minikube start: 40.4s 39.4s 39.5s 39.2s 38.2s
Times for minikube (PR 22182) start: 40.0s 38.9s 41.6s 40.0s 39.9s

docker driver with docker runtime

┌───────────────────┬──────────┬────────────────────────┐
│      COMMAND      │ MINIKUBE │ MINIKUBE  ( PR 22182 ) │
├───────────────────┼──────────┼────────────────────────┤
│ minikube start    │ 24.1s    │ 24.2s                  │
│ ⚠️  enable ingress │ 10.7s    │ 16.7s ⚠️                │
└───────────────────┴──────────┴────────────────────────┘

Details

Times for minikube start: 24.5s 23.4s 25.3s 22.7s 24.6s
Times for minikube (PR 22182) start: 23.7s 25.5s 23.2s 24.8s 23.8s

Times for minikube ingress: 10.7s 10.7s 10.7s 10.7s 10.7s
Times for minikube (PR 22182) ingress: 10.7s 10.7s 40.7s 10.7s 10.7s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22182 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.0s    │ 22.0s                  │
│ enable ingress │ 23.3s    │ 22.9s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube (PR 22182) start: 23.0s 21.4s 21.5s 21.0s 23.3s
Times for minikube start: 23.9s 23.4s 21.5s 22.0s 19.1s

Times for minikube ingress: 23.1s 24.1s 23.1s 23.1s 23.1s
Times for minikube (PR 22182) ingress: 23.2s 23.2s 22.1s 23.1s 23.2s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
KVM_Linux (5 failed)	TestFunctionalNewestKubernetes/Versionv1.35.0-rc.1/serial/SoftStart(gopogh)	Unknown
KVM_Linux (5 failed)	TestFunctionalNewestKubernetes/Versionv1.35.0-rc.1/serial/ExtraConfig(gopogh)	Unknown
KVM_Linux (5 failed)	TestFunctionalNewestKubernetes/Versionv1.35.0-rc.1/serial/ComponentHealth(gopogh)	Unknown
KVM_Linux (5 failed)	TestFunctional/serial/ExtraConfig(gopogh)	0.00% (chart)
KVM_Linux (5 failed)	TestFunctional/serial/ComponentHealth(gopogh)	0.00% (chart)

Besides the following environments also have failed tests:

• KVM_Linux_crio: 15 failed (gopogh)

• Docker_Linux_containerd_arm64: 34 failed (gopogh)

• Docker_Linux_crio_arm64: 44 failed (gopogh)

• Docker_Linux_crio: 28 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[afbjorklund]

Why not do this in libmachine instead? Seems a bit duplicated, to have it both in "ssh" and "sshkeys"

 	"github.com/docker/machine/libmachine/log"
 	"github.com/docker/machine/libmachine/mcnflag"
 	"github.com/docker/machine/libmachine/mcnutils"
-	"github.com/docker/machine/libmachine/ssh"
 	"github.com/pkg/errors"

 	"k8s.io/klog/v2"
 	"k8s.io/minikube/pkg/minikube/run"
 	"k8s.io/minikube/pkg/util"
+	"k8s.io/minikube/pkg/util/sshkeys"

• Remove old references to docker machine #21619