5th. Feat(Bento, #280): Use legacy settings rail menu and localization #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the `BentoRail` composable with the `HomeSettingDrawerSheet` within the `BentoMainScreen`. This change centralizes the settings UI and its logic, improving code organization and removing redundant implementations. Key changes include: - `BentoActivity` now inherits from `BreadActivity` to reuse existing functionality and handle legacy UI events via `EventBus`. - The dark mode toggle logic is moved out of the `SettingsViewModel` and is now managed directly by `DarkModeState` within the `HomeSettingDrawerSheet`, simplifying state management. - `BreadActivity` fields and methods are made `protected` to allow access from the derived `BentoActivity`. - Redundant code related to the old settings rail has been removed from `BentoMainScreen` and `SettingsViewModel`.
This commit introduces localization for various UI components by adding string resources for 19 new languages: Arabic, German, Spanish, Farsi, French, Hindi, Indonesian, Italian, Japanese, Korean, Punjabi, Polish, Portuguese, Russian, Swedish, Turkish, Ukrainian, and both Simplified and Traditional Chinese. Specific changes include: - Externalizing hardcoded strings in the `design-system`, `ltc`, `gamehub`, and `tutorial` modules to use `stringResource`. - Adding translated `strings.xml` files for each supported language within these modules. - Updating Gradle build files to include the new language configurations, ensuring they are correctly packaged.
Contributor
Author
|
Sorry still a lot cause of localization @kcw-grunt , already trimming down to 2 commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR modernizes the home experience by replacing the legacy
BentoRailwith the newHomeSettingDrawerSheet, consolidating settings UI and simplifying state management. In addition, full localization support is introduced across multiple modules, adding translated resources for 19 languages.Platform
🎯 Type of Change
📋 Changes
🔧 Replace BentoRail with HomeSettingDrawerSheet
BentoRailcomposable and integrated theHomeSettingDrawerSheetintoBentoMainScreen.BentoActivityto inherit fromBreadActivity, leveraging shared functionality and enabling legacy UI events viaEventBus.BreadActivitymethods and fields toprotectedsoBentoActivitycan extend them safely.SettingsViewModeldirectly intoDarkModeStatewithin the drawer sheet.BentoMainScreenandSettingsViewModel.✨ Localization for Multilingual Support
strings.xmlfiles for 19 languages:Arabic, German, Spanish, Farsi, French, Hindi, Indonesian, Italian, Japanese, Korean, Punjabi, Polish, Portuguese, Russian, Swedish, Turkish, Ukrainian, Simplified Chinese, and Traditional Chinese.
design-system,ltc,gamehub, andtutorialmodules.🔗 Related Issues
🧪 Tests Status
🎯 Reviewers
@kcw-grunt, @josikie