4th. Feat(Bento): Balance and Fiat Integration #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several key changes to the Bento main screen and related components:
- **Integrates `FragmentSend`**: The "Send" functionality is now displayed within a `ModalBottomSheet` on the Bento main screen, replacing the previous full-screen fragment navigation. `BentoActivity` now extends `FragmentActivity` to support this.
- **Improves `BentoMainScreenState`**: A `SheetType` enum (`DISMISSED`, `RECEIVE`, `SEND`) is introduced to manage the state of the bottom sheet, allowing it to display different content (Send, Receive) or be dismissed.
- **Refactors Price Ticker**:
- The price ticker logic is extracted into a `PriceTickerStateFlow` and its implementation, `PriceTickerStateFlowImpl`. This provides real exchange rate data instead of hardcoded values.
- `PriceTickerGrid` now uses a dedicated `PriceTickerGridUiState` to manage its state, consuming data from the new flow.
- **Removes old animation logic**: The custom slide and dim animations in `FragmentSend` have been removed in favor of the standard `ModalBottomSheet` behavior. The close button now uses the activity's back press handler.
This commit introduces the ability for users to tap on their balance to toggle the display between Litecoin (LTC) and their selected fiat currency. Key changes: * The main balance display is now clickable, allowing users to switch between the LTC and fiat currency values. * The `BalanceBentoGrid` no longer handles navigation clicks; this responsibility is now managed at a higher level. * A new `CurrentCurrencyStateFlow` has been introduced to observe changes in the user's selected currency. * The `PriceTickerGrid` has been updated to display the price ticker that corresponds to the currently selected currency, instead of showing a pager for all available pairs. * The `PriceTickerGrid` and `TransactionHistoryGrid` components and their associated state management have been moved into their own sub-packages for better organization.
This change introduces the ability to override the default "close" button action in the `FragmentSend` screen. Previously, the close button was hardcoded to trigger `onBackPressed()`. Now, a new `overrideOnCloseClicked` function allows parent components, like the `BentoMainScreen`, to provide a custom callback. This is used to correctly dismiss the bottom sheet when the send fragment is presented within it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📱 Description
This PR refines the Bento main screen's interaction model, integrates the Send screen into a bottom-sheet workflow, enhances balance and currency handling, and restructures several components for clearer state management and modularity. It also introduces a flexible override mechanism for the Send screen’s close action.
Platform
🎯 Type of Change
📋 Changes
✨ Send Screen Integration & Bottom Sheet Improvements
FragmentSendinto the Bento experience via aModalBottomSheet.BentoActivityto extendFragmentActivityto support fragment-backed bottom sheets.SheetTypeenum (DISMISSED,RECEIVE,SEND) inBentoMainScreenStateto manage sheet state and content switching.FragmentSend; relies on standard bottom-sheet behaviors.onBackPressed()via the activity's handler.✨ Balance Toggle Between LTC and Fiat
BalanceBentoGrid; now handled at a higher level.CurrentCurrencyStateFlowto observe and react to currency selection changes.🔧 Price Ticker Refactor & State Improvements
PriceTickerStateFlowandPriceTickerStateFlowImpl, providing real exchange rate data.PriceTickerGridUiStatefor dedicated UI state management.PriceTickerGridto display only the ticker for the currently selected currency (no more pager of multiple pairs).PriceTickerGridandTransactionHistoryGridplus their state classes into dedicated sub-packages for clearer structure.✨ FragmentSend Close Behavior Override
overrideOnCloseClickedto allow parent components to supply a custom close action.BentoMainScreento correctly dismiss the bottom sheet when Send is opened inside it.🔗 Related Issues
🧪 Tests Status
🎯 Reviewers
@kcw-grunt, @josikie