-
Notifications
You must be signed in to change notification settings - Fork 2
1st. Feat(Bento): Implement First Iteration bento design #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bento
Are you sure you want to change the base?
Conversation
This commit introduces the `BalanceBentoGrid` composable, a new component for the home screen's bento layout. Key changes include: - A dedicated `BalanceBentoGrid` composable to display LTC and USD balances. - A visibility toggle (eye icon) to show or hide balance information, enhancing privacy. The state is animated with a fade effect. - New vector assets for the enabled and disabled eye icons. - Edge-to-edge display is enabled in `BentoActivity` for a more immersive UI. - The `BentoMainScreen` is updated to use the new balance grid and to respect system window insets (`statusBarsPadding` and `navigationBarsPadding`). - Gradle packaging rules are updated to exclude duplicate license files.
Introduces a new `TransactionHistoryGrid` Composable in the LTC module. This component displays a placeholder for the transaction history on the main screen. The `BentoMainScreen` is updated to integrate this new component into the grid layout, replacing a generic `BentoHomeGrid` item.
Introduces a new `PriceTickerGrid` composable to display cryptocurrency trading pair prices. This component features a horizontally swipeable pager to cycle through different trading pairs, such as LTC/USD and LTC/BTC, with pagination indicators. The new grid has been integrated into the `BentoMainScreen` layout.
Introduces a new "Favorites" grid component to the main Bento screen. This new grid displays a list of favorite contacts as circular avatars. It also includes an "Add" button to allow users to add new contacts. The component is added to the main screen layout, replacing a placeholder grid item.
|
If you’d like a commit-by-commit review from the past month, this is the first phase of Bento, including the glass → opacity container changes. If this works for you, I’ll create the next PRs step by step. @kcw-grunt if okay with it we can merged this to reduce the changes |
| .statusBarsPadding() | ||
| .navigationBarsPadding() | ||
| ) { | ||
| AnimatedLightBleedBackground( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to a ios common name for reference the. I added this note before . Dont hardcode layer naming.
Notes: @JosephSanjaya
I would like to further name this in the comments so that when we compare iOS and Android the code is easily found. .. I dunno on the name but iOS is no better (GridWaveContentView)
Ideas:
Please dont refer it to as Background....View is better because where it is in the view hierarchy is irrelevant.
Here are your choices:
- AnimatedWaveView
- ShaderWaveView
- AnimatedShaderView
cc: @josikie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done renaming to AnimatedShaderView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kcw-grunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note naming function comments in the view
The composable `AnimatedLightBleedBackground` has been renamed to `AnimatedShaderView` to better reflect its more general purpose as a view that renders animated shaders, rather than being specific to a "light bleed" effect. This change is applied across the design system module and its usages, including the `BentoMainScreen` and the preview file.
|
Do you want me to change all new composable with View suffix? @kcw-grunt |
📱 Description
This PR introduces several new grid components to the Bento home screen, expanding functionality and improving the overall UI structure. The update brings dedicated composables for balances, price tickers, LTC transaction history, and favorite contacts.
Platform
🎯 Type of Change
📋 Changes
BalanceBentoGridcomposable for LTC and USD balance display.PriceTickerGridcomposable with horizontally swipeable pager to display trading pair prices (e.g., LTC/USD, LTC/BTC).TransactionHistoryGridcomposable for displaying LTC transaction history placeholders.BentoMainScreenlayout to integrate all new grid components.statusBarsPadding()andnavigationBarsPadding().BentoActivityfor a more immersive UI.🔗 Related Issues
🧪 Tests Status
📸 Screenshots/Videos
🎯 Reviewers
@kcw-grunt, @josikie