Add basic Sentry tracing instrumentation #4
Conversation
src/sentry.tsx
Outdated
| } | ||
| const transaction = (tracingIntegration as any).constructor.getTransaction(); | ||
| if (!transaction) { | ||
| console.warn("startSpan called without transaction"); |
There was a problem hiding this comment.
doesnt need to be a warning as its super common..
i also likely need to add new styles of transactions here. not sure what yet, but maybe when someone presses a tile its a new transaction. will experiment and see what can create value for patterns.
src/hass.tsx
Outdated
| resolve(payload); | ||
| } else if (payload.error) { | ||
| if (span) { | ||
| span.setStatus(SpanStatus.UnknownError); |
There was a problem hiding this comment.
understanding how to map other systems status codes to our status codes will be a challenge for folks.. going to try an exercise of doing this w/ hass
dcramer
force-pushed
the
feat/tracing-instrumentation
branch
from
43f1159 to
c2d6c66
Compare
| console.warn("startSpan called without tracing integration"); | ||
| return null; | ||
| } | ||
| const transaction = (tracingIntegration as any).constructor.getTransaction(); |
There was a problem hiding this comment.
its not ideal that we have to attach a span to a transaction (aka we cant always return a span)
dcramer
force-pushed
the
feat/tracing-instrumentation
branch
from
c2d6c66 to
d3d83a6
Compare
| return transaction.startChild(options); | ||
| }; | ||
|
|
||
| export const startTransaction = (options: { |
There was a problem hiding this comment.
this doesnt actually seem to work well.. to some degree i wanted to manually bind a transaction but the tracing integration couples them to itself, and theres no real APIs afaik to manage them without the idle helper
There was a problem hiding this comment.
Can't you just use Sentry.startTransaction https://github.com/EvanPurkhiser/prolink-connect/blob/master/src/network.ts#L102
There was a problem hiding this comment.
damn - didnt find that one :(
dcramer
force-pushed
the
feat/tracing-instrumentation
branch
from
d3d83a6 to
8ece59c
Compare
|
|
||
| handleOnTouch = async () => { | ||
| if (!this.onTouch) return; | ||
| Sentry.withScope(async (scope) => { |
There was a problem hiding this comment.
this isnt actually overriding transaction names for these events, which means we end up with 'panelkit.boot' for all transactions
No description provided.