Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 16, 2025

Reference interfaces for L2s, like #35271.

"chore" because I plan to make a lot of these PRs and they're not adding value to the changelog.

(Generated with AI)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Reference interfaces for L2s, like #35271.

"chore" because I plan to make a lot of these PRs and they're not adding value to the changelog.

(Generated with AI)
@rix0rrr rix0rrr requested a review from a team December 16, 2025 15:56
@github-actions github-actions bot added the p2 label Dec 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2025 15:56
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 16, 2025
@github-actions
Copy link
Contributor

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results52 ran50 passed2 failed
TestResult
Security Guardian Results
packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/sqs/integ.sqs-event-rule-target.js.snapshot/aws-cdk-sqs-event-target.template.json
sqs-encryption-enabled.guard❌ failure
sqs-no-world-accessible-inline.guard❌ failure

@github-actions
Copy link
Contributor

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates52 ran50 passed2 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/sqs/integ.sqs-event-rule-target.js.snapshot/aws-cdk-sqs-event-target.template.json
sqs-encryption-enabled.guard❌ failure
sqs-no-world-accessible-inline.guard❌ failure

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 16, 2025
@rix0rrr rix0rrr marked this pull request as draft December 17, 2025 09:51
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Dec 17, 2025

We can't merge this. The identifiers here are confused.

The spec says that the primary identifier is the Id field, the CloudFormation docs say that it's the ARN field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants