Skip to content

fix(led-matrix painter): fix c++ code preview generation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucarin91 wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix(led-matrix painter): fix c++ code preview generation #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a5e797
fix(led-matrix painter): fix c++ code preview generation
lucarin91 Dec 19, 2025
164c599
fixup! fix(led-matrix painter): fix c++ code preview generation
lucarin91 Dec 19, 2025
271103b
fixup! fixup! fix(led-matrix painter): fix c++ code preview generation
lucarin91 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions examples/led-matrix-painter/python/app_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# SPDX-License-Identifier: MPL-2.0

import json
import re
from arduino.app_utils import Frame

class AppFrame(Frame):
Expand Down Expand Up @@ -146,10 +147,11 @@ def to_c_string(self) -> str:
Returns:
str: C source fragment containing a const array initializer.
"""
c_type = "uint32_t"
c_type = "uint8_t"
snake_name = re.sub(r'[^a-zA-Z0-9]', '_', self.name.lower())
scaled_arr = self.rescale_quantized_frame(scale_max=255)

parts = [f"const {c_type} {self.name}[] = {{"]
parts = [f"{c_type} {snake_name} [] = {{"]
rows = scaled_arr.tolist()
# Emit the array as row-major integer values, preserving row breaks for readability
for r_idx, row in enumerate(rows):
Expand Down