feat: Migrate codebase and dependencies to Java 17 #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to 2.15.4, okhttp to 4.12.0, wiremock to 2.27.2. Refactored `AttachmentsApiTest`. Resteasy changed order in the new version.
dimitrystd
requested review from
DmitryBochorishvili,
PavloMyrotiuk,
bloy-smartling,
dnetrebenko-smartling,
maescomua,
sl-pkryshtop and
vbarhatov
dimitrystd
requested review from
AlexArcher,
AlexanderNovak,
klegins-smartling and
sl-mmuradov
as code owners
sl-pkryshtop
approved these changes
Dec 1, 2025
| <dependency> | ||
| <groupId>javax.annotation</groupId> | ||
| <artifactId>javax.annotation-api</artifactId> | ||
| <version>1.3.2</version> |
Contributor
There was a problem hiding this comment.
you can drop version here, it is defined in dependencyManagement
sl-mmuradov
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
I think we have to change the major version of sdk itsefl (1.26... --> 2.0.0)
Contributor
Author
There was a problem hiding this comment.
Sure, change the version and a couple more minor tweaks.
The purpose of this PR is to inform everyone that there will be a new major version (since all teams are actively working on updating services).
Contributor
Author
|
Okay, I take no comments as no objections. I'm closing this PR and releasing version 2.0.0. |
|
@dimitrystd, are we going to do the same branch for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To All: I have no plans to merge this PR; it is only for visibility.
There is no way to keep
smartling-api-commonsfree of CVEs while continuing to support Java 8. I made only the necessary changes to migrate the code and dependencies to Java 17. This means that the SDK will exist in two versions, requiring each new development (endpoint) to be implemented twice.I'd like to encourage all teams to migrate their services from 1.x to the new 2.x (when it is released).