-
Notifications
You must be signed in to change notification settings - Fork 13
Add address selection bottom sheet to a sample and show in response to delivery start event #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kiftio
wants to merge
11
commits into
prototype/preview-1
Choose a base branch
from
dk/address-picker
base: prototype/preview-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ea32f9 to
06fdd67
Compare
1a97e64 to
02f9809
Compare
2f726ea to
be5734a
Compare
Accept app authentication token
optimize imports and remove unused AppBarState
c6be74a to
4d1aef8
Compare
be5734a to
c26c529
Compare
kiftio
commented
Nov 13, 2025
| .setEmail("example.customer@shopify.com") | ||
| .setCountryCode(Storefront.CountryCode.CA) | ||
| .setPhone("+441792123456") | ||
| .setEmail("john.smith@example.com") |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switching over to US addresses as the demo stores we're using are US only
77910db to
3c4871c
Compare
Base automatically changed from
prototype/development
to
prototype/preview-1
November 14, 2025 17:40
3bf8c52 to
6fab619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Instead of immediately responding to the
deliveryAddressChangeRequestedevent, show an address selector, and respond with the selected event.Note: I ran optimize imports, so we have some unused import removals. I'll look into configuring adding this as a pre-check
How to test
Run the sample
Click vaulted address picker
Observe picker
Select address
Observe checkout is updated with new addres
Before you merge
Important
Checklist for releasing a new version
build.gradlefileTip
See the Contributing documentation for instructions on how to publish a new version of the library.