Elasticsearch Integration for Beneficiary Search #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

vanitha1822 wants to merge 6 commits into release-3.6.0 from nd/vs/elastic_search_1951

Contributor

vanitha1822 commented Dec 6, 2025

📋 Description

JIRA ID:

✅ Type of Change

✨ New feature (non-breaking change which adds functionality)


          fix: ES Implementation-mapping, indexing and async records

15580de

coderabbitai bot commented Dec 6, 2025 •

edited

Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch nd/vs/elastic_search_1951

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vanitha1822 requested a review from drtechie

December 6, 2025 06:00

vanitha1822 marked this pull request as draft

December 6, 2025 06:00

vanitha1822 self-assigned this

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/iemr/common/identity/service/IdentityService.java Fixed Show fixed Hide fixed

drtechie reviewed

View reviewed changes

src/main/java/com/iemr/common/identity/service/elasticsearch/AsyncElasticsearchSyncService.java Outdated

    
               * Runs sync jobs in background without blocking API calls

               */

              @Service

              public class AsyncElasticsearchSyncService {

Member

drtechie Dec 6, 2025

The context of "Async" and "sync" of document to Elasticsearch are 2 different things.
Is ASync prefix necessary?

Contributor Author

vanitha1822 Dec 8, 2025

For my reference, I kept for now. I will change once everything is completed.


          fix: add service for ES Search

4020c1d

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/controller/IdentityESController.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchService.java Fixed Show fixed Hide fixed


          fix: search implementation

5b751f2

github-advanced-security bot found potential problems

View reviewed changes

...main/java/com/iemr/common/identity/controller/elasticsearch/ElasticsearchSyncController.java

    
                  @PostMapping("/single/{benRegId}")

                  public ResponseEntity<Map<String, Object>> syncSingleBeneficiary(

                          @PathVariable String benRegId) {

                      logger.info("Received request to sync single beneficiary: {}", benRegId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

...main/java/com/iemr/common/identity/controller/elasticsearch/ElasticsearchSyncController.java

    
                  @GetMapping("/debug/check/{benRegId}")

                  public ResponseEntity<Map<String, Object>> checkBeneficiaryExists(

                          @PathVariable String benRegId) {

                      logger.info("Checking if beneficiary exists: {}", benRegId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchService.java Fixed Show fixed Hide fixed

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchSyncService.java

    
                  public boolean syncSingleBeneficiary(String benRegId) {

                      try {

                          logger.info("========================================");

                          logger.info("Syncing single beneficiary with BenRegId: {}", benRegId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchSyncService.java

    
                          // Check if beneficiary exists in database first using transactional wrapper

                          boolean exists = transactionalWrapper.existsByBenRegId(benRegIdBig);

                          if (!exists) {

                              logger.error("Beneficiary does not exist in database: BenRegId={}", benRegId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchSyncService.java

    
                          BeneficiariesDTO benDTO = beneficiaryDataService.getBeneficiaryFromDatabase(benRegIdBig);

                          if (benDTO == null) {

                              logger.error("Failed to fetch beneficiary details from database: BenRegId={}", benRegId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchSyncService.java

    
                          BeneficiaryDocument doc = convertToDocument(benDTO);

                          if (doc == null || doc.getBenId() == null) {

                              logger.error("Failed to convert beneficiary to document: BenRegId={}", benRegId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchSyncService.java

    
                          logger.info("========================================");

                          logger.info("SUCCESS! Beneficiary synced to Elasticsearch");

                          logger.info("BenRegId: {}, BenId: {}", benRegId, doc.getBenId());

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

src/main/java/com/iemr/common/identity/service/elasticsearch/SyncJobService.java

    
                      // Save job to database

                      job = syncJobRepository.save(job);

                      logger.info("Created new full sync job: jobId={}, triggeredBy={}", job.getJobId(), triggeredBy);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud


          fix: add additional fields as per the requirement

502f3e0

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/iemr/common/identity/service/elasticsearch/ElasticsearchService.java

    
                   * Universal search with optional user location for ranking

                   */

                  public List<Map<String, Object>> universalSearch(String query, Integer userId) {

                      logger.info("Universal ES search for: {} with userId: {}", query, userId);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud

vanitha1822 added 2 commits

December 15, 2025 14:39


          fix: comment extra fields

fe8980c


          fix: rename the files, remove commented code

9446a10

sonarqubecloud bot commented Dec 16, 2025

Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Contributor Author

vanitha1822 commented Dec 16, 2025

Track in PR #123

vanitha1822 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet