Update signif digits for sim_gs_n() test to verify bounds from {gsDesign2}
#355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleBeannie
approved these changes
Nov 20, 2025
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thank you for your timely help, @jdblischak !
Collaborator
Author
|
I confirmed that now {gsDesign2} 1.1.7 is being installed in the GitHub Actions builds. https://github.com/Merck/simtrial/actions/runs/19551118309/job/55982596200?pr=355#step:5:4206 |
jdblischak
force-pushed
the
sim-gs-n-bounds-gsdesign2-117
branch
from
2ac6825 to
4a64434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #354
The bounds returned by {gsDesign2} changed slightly between versions 1.1.6 and 1.1.7. This PR relaxes the stringency of the test to 6 significant digits, which is sufficient to verify the asymptotic theory.