Skip to content

Conversation

@ananas-block
Copy link

  • Add in_accounts and batch_nullify_context hashes to kept_account_hashes in filter_by_known_trees, so spend transaction entries are not filtered out
  • Remove filter in v2 parser that excluded input accounts also present in outputs, making v2 consistent with v1 behavior

Overview

  • Summary of changes

Testing

  • Testing performed to validate the changes

- Add in_accounts and batch_nullify_context hashes to kept_account_hashes
  in filter_by_known_trees, so spend transaction entries are not filtered out
- Remove filter in v2 parser that excluded input accounts also present in
  outputs, making v2 consistent with v1 behavior
@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jorrit/fix-get-compression-signatures-for-account-spend

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants