fix: usage of deleted yaml.safeLoad #771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Since major version 4 of js-yaml usage of
yaml.safeLoadwill throw an error.Since the upgrade of ibm-openapi-validator to version 1.37.4 the
js-yamlwas switched from3.14.1to4.1.1and now we're getting errors like:This is fixing this issue.
Important: The tests are already covering this issue. It is not very clear to me why in your build pipeline this was not already covered. Maybe the old version is there still cached?
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
.secrets.baselinehas been updated as needednpm run update-utilitieshas been run if any files inpackages/utilities/srchave been updatedChecklist for adding a new validation rule: