Save which partner mods were installed when essential was installed. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJtheRedstoner
suggested changes
Jun 27, 2025
| if (is == null) throw new IllegalStateException("No bundled container jar found!"); | ||
| Files.copy(is, destination); | ||
| } | ||
| Path metadataDestination = Paths.get("essential", "integration-mod-metadata.json"); |
Contributor
There was a problem hiding this comment.
Extract this into a separate method, which is called just before the return.
| JsonObject metadata = new JsonObject(); | ||
| JsonArray partnerArray = new JsonArray(); | ||
| for (PartnerModData.PartnerMod partnerMod : partnerMods) { | ||
| partnerArray.add(partnerMod.getId()); |
Contributor
There was a problem hiding this comment.
Compile error on 1.8.9 here due to GSON API differences.
Comment on lines
84
to
85
| EssentialPartner.LOGGER.warn("Failed to store telemetry file to {}", metadataDestination.toRealPath()); | ||
| EssentialPartner.LOGGER.warn("Error:", e); |
Contributor
There was a problem hiding this comment.
Suggested change
| EssentialPartner.LOGGER.warn("Failed to store telemetry file to {}", metadataDestination.toRealPath()); | |
| EssentialPartner.LOGGER.warn("Error:", e); | |
| EssentialPartner.LOGGER.warn("Failed to store telemetry file to {}", metadataDestination.toRealPath(), e); |
RedEpicness
force-pushed
the
feature/add-partner-list-metadata
branch
from
c54a36d to
4cd1aaa
Compare
RedEpicness
force-pushed
the
feature/add-partner-list-metadata
branch
from
4cd1aaa to
4aa818c
Compare
DJtheRedstoner
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.