Register CLEM PNGs #719
Open
Register CLEM PNGs #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-server' as a key is no longer needed
…sses in; removed CustomHandler
…, as it is no longer needed
…ter thumbnail images for ISPyB with
…fferent fields are used for
…formation about the thumbnails used when registering data to ISPyB
…M workflow to make use of scaled down thumbnails instead of full-sized TIFFs
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 43.50% 43.60% +0.10%
==========================================
Files 94 94
Lines 10233 10255 +22
Branches 1331 1333 +2
==========================================
+ Hits 4452 4472 +20
Misses 5560 5560
- Partials 221 223 +2 🚀 New features to boost your workflow:
|
tieneupin
requested review from
d-j-hatton and
stephen-riggs
and removed request for
stephen-riggs
tieneupin
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after PR #716 and #718.
The large diff is due to this branch being built off of other branches, and should go down once those have been merged.
TIFF images/image stacks cannot be displayed natively in a web browser. To allow the CLEM data to be correctly rendered in PATo, we need to generate thumbnails of datasets that are in a web browser-friendly format.
This PR updates the CLEM processing result registration workflows to look for and register thumbnails and the size scales associated with them in ISPyB, which should then allow them to be correctly viewed on PATo.