-
Notifications
You must be signed in to change notification settings - Fork 0
Mimas: more flexible/exensible handling of scenario #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthchirp
approved these changes
Dec 14, 2021
Contributor
Anthchirp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool. Love it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an entry points mechanism to allow enable a more flexible and extensible approach to handling scenarios in mimas.
The simplest mechanism is to register one (or more) functions that take a scenario and return a list of
MimasRecipeInvocations orMimasISPyBJobInvocations:This function will handle every scenario passed to the mimas service. Alternatively, a more modular approach can be used, using the
@match_specificationdecorator to filter scenarios that match a given specification before passing them to the function:Various commonly used specifications are provided, such as
BeamlineSpecification,DCClassSpecification,DetectorClassSpecification,EventSpecificationandVisitSpecification. More complex custom specifications may be built by inheriting fromScenarioSpecification. Specifications can be combined using bitwise operators (&,|,~).Once this is merged, I would suggest moving the non-DLS-specific components to the python-zocalo repository (see also DiamondLightSource/python-zocalo#129).