testing

Author: gargsaumya

.github/workflows/post-coverage-comment.yml

@@ -18,11 +18,12 @@ jobs:
 
     steps:
       - name: Download coverage data
-        uses: actions/download-artifact@v4
-        with:
-          name: coverage-comment-data
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          run-id: ${{ github.event.workflow_run.id }}
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh run download ${{ github.event.workflow_run.id }} \
+            --repo ${{ github.repository }} \
+            --name coverage-comment-data
 
       - name: Read coverage data
         id: coverage
@@ -34,32 +35,36 @@ jobs:
           
           cat pr-info.json
           
-          # Extract values from JSON
-          PR_NUMBER=$(jq -r '.pr_number' pr-info.json)
-          COVERAGE_PCT=$(jq -r '.coverage_percentage' pr-info.json)
-          COVERED_LINES=$(jq -r '.covered_lines' pr-info.json)
-          TOTAL_LINES=$(jq -r '.total_lines' pr-info.json)
-          PATCH_PCT=$(jq -r '.patch_coverage_pct' pr-info.json)
-          LOW_COV_FILES=$(jq -r '.low_coverage_files' pr-info.json)
-          PATCH_SUMMARY=$(jq -r '.patch_coverage_summary' pr-info.json)
-          ADO_URL=$(jq -r '.ado_url' pr-info.json)
+          # Extract values from JSON with proper quoting
+          PR_NUMBER="$(jq -r '.pr_number' pr-info.json)"
+          COVERAGE_PCT="$(jq -r '.coverage_percentage' pr-info.json)"
+          COVERED_LINES="$(jq -r '.covered_lines' pr-info.json)"
+          TOTAL_LINES="$(jq -r '.total_lines' pr-info.json)"
+          PATCH_PCT="$(jq -r '.patch_coverage_pct' pr-info.json)"
+          LOW_COV_FILES="$(jq -r '.low_coverage_files' pr-info.json)"
+          PATCH_SUMMARY="$(jq -r '.patch_coverage_summary' pr-info.json)"
+          ADO_URL="$(jq -r '.ado_url' pr-info.json)"
           
-          # Export to env for next step
-          echo "PR_NUMBER=$PR_NUMBER" >> $GITHUB_ENV
-          echo "COVERAGE_PERCENTAGE=$COVERAGE_PCT" >> $GITHUB_ENV
-          echo "COVERED_LINES=$COVERED_LINES" >> $GITHUB_ENV
-          echo "TOTAL_LINES=$TOTAL_LINES" >> $GITHUB_ENV
-          echo "PATCH_COVERAGE_PCT=$PATCH_PCT" >> $GITHUB_ENV
-          echo "ADO_URL=$ADO_URL" >> $GITHUB_ENV
+          # Export to env for next step (single-line values)
+          echo "PR_NUMBER=${PR_NUMBER}" >> $GITHUB_ENV
+          echo "COVERAGE_PERCENTAGE=${COVERAGE_PCT}" >> $GITHUB_ENV
+          echo "COVERED_LINES=${COVERED_LINES}" >> $GITHUB_ENV
+          echo "TOTAL_LINES=${TOTAL_LINES}" >> $GITHUB_ENV
+          echo "PATCH_COVERAGE_PCT=${PATCH_PCT}" >> $GITHUB_ENV
+          echo "ADO_URL=${ADO_URL}" >> $GITHUB_ENV
           
-          # Handle multiline values
-          echo "LOW_COVERAGE_FILES<<EOF" >> $GITHUB_ENV
-          echo "$LOW_COV_FILES" >> $GITHUB_ENV
-          echo "EOF" >> $GITHUB_ENV
+          # Handle multiline values with proper quoting
+          {
+            echo "LOW_COVERAGE_FILES<<EOF"
+            echo "$LOW_COV_FILES"
+            echo "EOF"
+          } >> $GITHUB_ENV
           
-          echo "PATCH_COVERAGE_SUMMARY<<EOF" >> $GITHUB_ENV
-          echo "$PATCH_SUMMARY" >> $GITHUB_ENV
-          echo "EOF" >> $GITHUB_ENV
+          {
+            echo "PATCH_COVERAGE_SUMMARY<<EOF"
+            echo "$PATCH_SUMMARY"
+            echo "EOF"
+          } >> $GITHUB_ENV
 
       - name: Comment coverage summary on PR
         uses: marocchino/sticky-pull-request-comment@v2

.github/workflows/pr-code-coverage.yml

@@ -420,18 +420,34 @@ jobs:
       - name: Save coverage data for comment
         run: |
           mkdir -p coverage-comment-data
-          cat > coverage-comment-data/pr-info.json << EOF
-          {
-            "pr_number": "${{ github.event.pull_request.number }}",
-            "coverage_percentage": "${{ env.COVERAGE_PERCENTAGE }}",
-            "covered_lines": "${{ env.COVERED_LINES }}",
-            "total_lines": "${{ env.TOTAL_LINES }}",
-            "patch_coverage_pct": "${{ env.PATCH_COVERAGE_PCT }}",
-            "low_coverage_files": $(jq -Rs . <<< "${{ env.LOW_COVERAGE_FILES }}"),
-            "patch_coverage_summary": $(jq -Rs . <<< "${{ env.PATCH_COVERAGE_SUMMARY }}"),
-            "ado_url": "${{ env.ADO_URL }}"
+          jq -n \
+            --arg pr_number "${{ github.event.pull_request.number }}" \
+            --arg coverage_percentage "${{ env.COVERAGE_PERCENTAGE }}" \
+            --arg covered_lines "${{ env.COVERED_LINES }}" \
+            --arg total_lines "${{ env.TOTAL_LINES }}" \
+            --arg patch_coverage_pct "${{ env.PATCH_COVERAGE_PCT }}" \
+            --arg low_coverage_files "${{ env.LOW_COVERAGE_FILES }}" \
+            --arg patch_coverage_summary "${{ env.PATCH_COVERAGE_SUMMARY }}" \
+            --arg ado_url "${{ env.ADO_URL }}" \
+            '{
+              pr_number: $pr_number,
+              coverage_percentage: $coverage_percentage,
+              covered_lines: $covered_lines,
+              total_lines: $total_lines,
+              patch_coverage_pct: $patch_coverage_pct,
+              low_coverage_files: $low_coverage_files,
+              patch_coverage_summary: $patch_coverage_summary,
+              ado_url: $ado_url
+            }' > coverage-comment-data/pr-info.json
+          
+          # Validate JSON before uploading
+          echo "Validating generated JSON..."
+          jq . coverage-comment-data/pr-info.json > /dev/null || {
+            echo "❌ Invalid JSON generated"
+            cat coverage-comment-data/pr-info.json
+            exit 1
           }
-          EOF
+          echo "✅ JSON validation successful"
           cat coverage-comment-data/pr-info.json
 
       - name: Upload coverage comment data