-
Notifications
You must be signed in to change notification settings - Fork 56
Open
Description
azCliUtility emits errors for transient failures:
azure-pipelines-tasks-common-packages/common-npm-packages/azure-arm-rest/azCliUtility.ts
Lines 198 to 204 in 680f186
| if (error.name === 'AggregateError' && error['errors'] !== undefined) { | |
| for (const err of error.errors) { | |
| tl.error(`Error while trying to get OIDC token: ${err}`); | |
| } | |
| } else { | |
| tl.error(`Error while trying to get OIDC token: ${error}`); | |
| } |
In my opinion above-mentioned tl.errors should be warnings
Emitting single error on failure should be enough:
if (retryCount >= MAX_CREATE_OIDC_TOKEN_RETRIES) {
throw Error(tl.loc('CouldNotFetchAccessTokenForAADRetryLimitExceeded'));
}Examples:
transient failure but authentication worked:
real failure:

Metadata
Metadata
Assignees
Labels
No labels