[Since RN@0.82] Problem with `node_modules/react-native/scripts/xcode/with-environment.sh`

[birdofpreyru]

Description

Ever since upgrading an existing app to RN@0.82, its build for iOS, on macOS build host, using Xcode fails for me:

It helps if I remove double quotes from this script line:

react-native/packages/react-native/scripts/xcode/with-environment.sh

Line 46 in 296f580

"$1"

turning "$1" into just $1 — after that the build works fine.

Can we make this change in RN (not sure if I am missing smth and it requires a different change, to work for scenarios different from mine)?

Steps to reproduce

Above.

React Native Version

0.82, 0.83

Affected Platforms

Build - MacOS

Output of npx @react-native-community/cli info

N/A

Stacktrace or Logs

N/A

MANDATORY Reproducer

N/A

Screenshots and Videos

No response

[react-native-bot]

Warning

Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2.

[react-native-bot]

Warning

Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2.

[react-native-bot]

Warning

Missing reproducer: We could not detect a reproducible example in your issue report. Reproducers are mandatory and we can accept only one of those as a valid reproducer:

• For majority of bugs: send us a Pull Request with the RNTesterPlayground.js edited to reproduce your bug.
• If your bug is UI related: a Snack
• If your bug is build/upgrade related: a project using our Reproducer Template

You can read more about about it on our website: How to report a bug.

[cipolleschi]

@birdofpreyru the change comes from here.

It's a bit surprising, because the build works fine for me. Do you have any special setup? What is $1 for you?

[birdofpreyru]

@cipolleschi yes, I have Sentry for RN integrated, which adds this build step, which causes the problem (and used to work fine prior RN@0.82):

00DD1BFF1BD5951E006B06BC /* Bundle React Native code and images */ = {
	isa = PBXShellScriptBuildPhase;
	buildActionMask = 2147483647;
	files = (
	);
	inputPaths = (
		"$(SRCROOT)/.xcode.env.local",
		"$(SRCROOT)/.xcode.env",
	);
	name = "Bundle React Native code and images";
	outputPaths = (
	);
	runOnlyForDeploymentPostprocessing = 0;
	shellPath = /bin/sh;
	shellScript = "set -e\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT \\\"/bin/sh ../node_modules/@sentry/react-native/scripts/sentry-xcode.sh $REACT_NATIVE_XCODE\\\"\"\n";
};

[bigcupcoffee]

Your script seems outdated and shouldn't refer to REACT_NATIVE_XCODE anymore then, please follow updated Sentry instructions

[birdofpreyru]

@bigcupcoffee you are right! After a reset of Sentry integration into my app everything works out of the box.

My bad, sorry! 🙏