goto-cc: Fix compilation with GCC 11

vmihalko · vmihalko · commit 9db8e6c06fbe · 2021-04-13T22:06:22.000+02:00
The reference type caused following error:
/builddir/build/BUILD/cbmc/src/goto-cc/ms_link_cmdline.cpp:337:26: error: loop variable 'ms_link_option' of type 'const string&amp;' {aka 'const std::__cxx11::basic_string&lt;char&gt;&amp;'} binds to a temporary constructed from type 'const char*' [-Werror=range-loop-construct]
  337 |   for(const std::string &amp;ms_link_option : ms_link_options)
      |                          ^~~~~~~~~~~~~~
/builddir/build/BUILD/cbmc/src/goto-cc/ms_link_cmdline.cpp:337:26: note: use non-reference type 'const string' {aka 'const std::__cxx11::basic_string&lt;char&gt;'} to make the copy explicit or 'const char* const&amp;' to prevent copying
diff --git a/src/goto-cc/ms_link_cmdline.cpp b/src/goto-cc/ms_link_cmdline.cpp
@@ -333,7 +333,7 @@ void ms_link_cmdlinet::process_link_option(const std::string &s)
     return;
   }
 
-  for(const std::string &ms_link_option : ms_link_options)
+  for(const std::string ms_link_option : ms_link_options)
   {
     // These are case insensitive.
     if(

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ void ms_link_cmdlinet::process_link_option(const std::string &s)`
`333`	`333`	`return;`
`334`	`334`	`}`
`335`	`335`
`336`		`- for(const std::string &ms_link_option : ms_link_options)`
	`336`	`+ for(const std::string ms_link_option : ms_link_options)`
`337`	`337`	`{`
`338`	`338`	`// These are case insensitive.`
`339`	`339`	`if(`